Re: [PATCH net-next] net: make ndo_get_stats64 a void function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
Date: Thu,  5 Jan 2017 09:31:36 -0800

> The network device operation for reading statistics is only called
> in one place, and it ignores the return value. Having a structure
> return value is potentially confusing because some future driver could
> incorrectly assume that the return value was used.
> Fix all drivers with ndo_get_stats64 to have a void function.
> Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>

You missed at least one new warning, please do a fresh allmodconfig build
and watch the logs.

drivers/net/ethernet/broadcom/bnx2.c: In function ʽbnx2_get_stats64ʼ:
drivers/net/ethernet/broadcom/bnx2.c:6830:10: warning: ʽreturnʼ with a value, in function returning void

?τθΊ{.nΗ+?·???­?+%?Λ?±ιέΆ??w?Ί{.nΗ+?·??{±ώ?iώ)ν?ζθw*jg¬±¨Ά????έʼj?Ύ«ώG«?ι?ʼΈʼ·¦j:+v?¨?wθjΨmΆ??ώψ―ω?w?ώ?ΰώf£ʼ·h??β?ϊ??Ω?

[Index of Archives]     [Linux Audio Users]     [Linux for Hams]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Fedora Users]

  Powered by Linux