> I have no idea why its a patch on its own, and why state->arc4 gets > special treatment while state->sha1 does not. I did not fiddle with the data structure element "sha1" because I assumed that it might be still relevant for the call of a function like crypto_free_blkcipher(). > This definitely belongs to the previous patch, refactoring error > handling in mppe_alloc() I have got different preferences for change distribution over several patches here. I find it safer to tackle an assignment clean-up after adjustments for jump labels. > Also, it seems your patches do not fix bugs, so so you need to target > net-next tree, as explained in Documentation/networking/netdev-FAQ.txt Do you want that I resend my update suggestion? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html