On 07/15/2014 06:54 AM, Christoph Schulz wrote:
Hello!
Daniel Borkmann schrieb am Sun, 13 Jul 2014 20:51:45 +0200:
I think going with the first variant is just fine.
Well, then I need not change anything, do I? This first variant causes checkpatch to warn twice about a line exceeding 80 characters:
WARNING: line over 80 characters
#83: FILE: drivers/net/ppp/ppp_generic.c:771:
+ err = sk_unattached_filter_create(&ppp->pass_filter,
WARNING: line over 80 characters
#102: FILE: drivers/net/ppp/ppp_generic.c:797:
+ err = sk_unattached_filter_create(&ppp->active_filter,
But I don't see how to shorten them. This is because "sk_unattached_filter_create" is such a long identifier...
Well, this is a soft-limit, and in this particular circumstance
it should be fine to use your original proposal. I don't see how
Varka's suggestions make this better in _any way_, rather the
very opposite.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
