On 07/12/2014 05:59 AM, Alexei Starovoitov wrote:
On Fri, Jul 11, 2014 at 9:10 AM, Christoph Schulz <develop@xxxxxxxxxx> wrote:From: Christoph Schulz <develop@xxxxxxxxxx> Commit 568f194e8bd16c353ad50f9ab95d98b20578a39d ("net: ppp: use sk_unattached_filter api") causes sk_chk_filter() to be called twice when setting a pass or active filter. The first call is from within get_filter(). The second one is through the call chain ppp_ioctl() --> sk_unattached_filter_create() --> __sk_prepare_filter() --> sk_chk_filter() However, sk_chk_filter() is not idempotent as it sometimes replaces filter codes. So running it a second time over the same filter does not work andIt's a good thing not to call sk_chk_filter() twice, but the commit log is incorrect. sk_chk_filter() doesn't replace filter codes anymore.
Exactly. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
