Dear kernel maintainers, I ran into an issue that causes "mppe_compress[%d]: osize too small! …" message to be printed. While debugging the issue, I stumbled across two additional issues with the code in question. 1) The printk gives a "have" and a "need" value. However the "need" value does not represent the actual need, because the printed need is based on the osize variable instead of the isize variable used in the test. This appears to by a typo an is as old as the ppp_mppe.c file. The first patch attached changes the parameter to printk to print the actual need. 2) The message in question can be triggered by network packets. If that happens, there are a lot of printks and the whole system slows down to a crawl. Whenever network packets are processed, the printks must be rate limited in some way, so my second patch adds a call to net_ratelimit(). Note that even though checkpatch suggested to convert the printks to netdev_dbg, I felt that a bug fix should be minimal and thus not change this aspect. Please consider these patches and CC me in replies. Helmut
Attachment:
0001-mppe-print-correct-osize-required-for-compression.patch
Description: Binary data
Attachment:
0001-mppe-rate-limit-osize-too-small.patch
Description: Binary data
