On Tue, 2013-05-21 at 20:18 +0200, Jorge Boncompte [DTI2] wrote:
> From: "Jorge Boncompte [DTI2]" <jorge@xxxxxxxx>
> if (!state->stateful) {
> + if (mppe_cmp_ccount(ccount, state->ccount) < 0) {
> + if (net_ratelimit())
> + printk(KERN_WARNING "%s[%d]: Dropping out-of-order "
> + "packet with ccount %u, "
> + "expecting %u!\n", __func__,
> + state->unit, ccount, state->ccount);
> + return DECOMP_DROPERROR;
> + }
You did not address my review, thats too bad.
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#107: FILE: drivers/net/ppp/ppp_mppe.c:483:
+
+/*
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
#117: FILE: drivers/net/ppp/ppp_mppe.c:564:
+ printk(KERN_WARNING "%s[%d]: Dropping out-of-order "
WARNING: quoted string split across lines
#118: FILE: drivers/net/ppp/ppp_mppe.c:565:
+ printk(KERN_WARNING "%s[%d]: Dropping out-of-order "
+ "packet with ccount %u, "
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
