On Tue, Jun 05, 2012 at 08:02:39PM +0300, Daniel Golle wrote: > I guess you are aware of > https://dev.openwrt.org/browser/trunk/package/ppp/patches > > Just as I haven't encountered any of them on git://ozlabs.org/~paulus/ppp.git > > Most of them make sense and apply cleanly, few are OpenWrt-specific. > > I'd suggest importing: The problem with distro patches like this is that they very often don't have any authorship information, sign-off or a decent patch description. Unless a patch is really trivial I need to know who the author is and that the author gives permission for me to include it. Without a decent patch description I have to reverse-engineer why the changes are being made, which is often not at all obvious. For example, what's the use case for 100-debian_ip-ip_option.patch? What are the circumstances where 101-debian_close_dev_ppp.patch would find a ppp_fd already open? And so on. I see that several of the patches on that page have a sign-off from Philip Prindeville, so presumably he wrote them and can give me a nod to include them. Philip? Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
