On 2010-11-23 22:43, Cyrill Gorcunov wrote: > Allocating unit from ird might return several error codes > not only -EAGAIN, so it should not be changed and returned > precisely. Same time unit release procedure should be invoked > only if device is unregistering. IMHO this unit release fix should be in a separate patch. ... > @@ -2668,10 +2668,10 @@ static void ppp_shutdown_interface(struc > ppp->closing = 1; > ppp_unlock(ppp); > unregister_netdev(ppp->dev); > + unit_put(&pn->units_idr, ppp->file.index); > } else > ppp_unlock(ppp); > > - unit_put(&pn->units_idr, ppp->file.index); > ppp->file.dead = 1; > ppp->owner = NULL; > wake_up_interruptible(&ppp->file.rwait); Btw, it seems these last 3 lines could be moved similarly. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
