Re: [PATCH 6/6] Use Disconnect-Cause=Admin-Reset if SIGTERM received

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



First off, thanks for putting together this set of patches.  This one
needs a little more explanation, however, concerning what the
distinction between the existing EXIT_USER_REQUEST and the new
EXIT_SIGTERM is.  Why do we need a separate code for kill -TERM vs.
kill -HUP?  And shouldn't a ^C at pppd's controlling terminal result
in EXIT_USER_REQUEST rather than EXIT_SIGTERM?

Adding a new EXIT_SIGTERM also has the possibility of breaking
existing scripts that look at pppd's exit code.  Plus, if we're going
to add it, it would need to be documented in pppd.8.

On the whole, I think it would be better just to make
EXIT_USER_REQUEST result in PW_ADMIN_RESET and drop the new
EXIT_SIGTERM.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Audio Users]     [Linux for Hams]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Fedora Users]

  Powered by Linux