From: Simon Arlott <simon@xxxxxxxxxxx>
Date: Fri, 30 Apr 2010 19:41:17 +0100
> @@ -1572,8 +1572,18 @@ ppp_input(struct ppp_channel *chan, struct sk_buff *skb)
> return;
> }
>
> - proto = PPP_PROTO(skb);
> +
> read_lock_bh(&pch->upl);
> + if (!pskb_may_pull(skb, 2)) {
> + kfree_skb(skb);
> + if (pch->ppp) {
> + ++pch->ppp->dev->stats.rx_length_errors;
> + ppp_receive_error(pch->ppp);
> + }
> + goto done;
> + }
> +
> + proto = PPP_PROTO(skb);
This makes the skb->len == 0 test at the beginning completely redundant.
Put your pskb_may_pull(skb, 2) call there and remove the skb->len==0
check entirely.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
