On Tue, Apr 06, 2010 at 10:30:02PM +0200, Sebastian Andrzej Siewior wrote: > > Good point. All arc4 users don't care about return value of setkey so I > think that I just change void to int add the check for the valid key > length. Actually, how about getting arc4_setup_iv to do all the legwork and turn it into a real IV? Then we don't need any checks on the data path. > While we are here, the .setkey() callback could be removed, couldn't it? > It returns 0 even it is doing nothing what looks kinda wrong. However it > shouldn't be called at all since min/max key is 0. Any objections on > that? I'm pretty sure testmgr will call setkey even for keylen == 0, no? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
