-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johannes Berg schrieb: > On Fri, 2009-10-23 at 16:27 +0200, Tilman Schmidt wrote: >> Johannes Berg schrieb: >>> So you've verified that the entire i4l stack can cope with being called >>> twice on the same CPU, from different contexts? >> What makes you think so? > > I thought I'd explained this in my other email. *sigh* [snip] Ah, I see. You misunderstood my posting. I did not propose that patch as a definitive and verified solution, but rather as a request for comments from the people who know and maintain the code in question. I thought that was clear from the facts that - - I didn't include "[PATCH]" in the subject line - - I didn't add a "Signed-off-by" line - - I wrote "fixed the messages", not "solved the problem" - - I explicitly wrote "Comments?" and "Adding i4l people to CC" Apparently all that was still not clear enough. Sorry about that. So let me try to make my concern as explicit as possible: - - The patch I posted had the effect that the test which reliably triggered the local_softirq_pending message before did not do so anymore. - - To me, this seems to indicate that the netif_rx(skb) call in line 1177 of source file drivers/isdn/i4l/isdn_ppp.c is indeed involved in the problem. - - Now I'm asking people who know more than myself about the ramifications of that message (ie., you) and/or the code I narrowed it down to (ie., the ISDN4Linux maintainers - which is why I added them to the CC list) to have a look and determine how to fix the problem properly. - - This would of course include, in finis, the verification you mistakenly assumed I might have done already. I hope that's clear enough. If you have any questions, feel free to ask. Thanks, Tilman - -- Tilman Schmidt E-Mail: tilman@xxxxxxx Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFK4drJQ3+did9BuFsRAmstAJ94UF/LupINlYpjbxzz9xoiN5w34wCfflRz YfR/fXt3HasrxUSP29REOnE= =VQ/C -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
