Michal Ostrowski a écrit : > Here's a bigger patch that just gets rid of flush_lock altogether. > > We were seeing oopses due to net namespaces going away while we were using > them, which turns out is simply due to the fact that pppoew wasn't claiming ref > counts properly. > > Fixing this requires that adding and removing entries to the per-net hash-table > requires incrementing and decrementing the ref count. This also allows us to > get rid of the flush_lock since we can now depend on the existence of > "pn->hash_lock". > > We also have to be careful when flushing devices that removal of a hash table > entry may bring the net namespace refcount to 0. > Your patch is mangled (tabulation -> white spaces), and I dont believe namespace refcount can reach 0 inside pppoe_flush_dev(), it would be a bug from core network code. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
