Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 21, 2007 at 04:08:09PM +0200, Michal Schmidt wrote:
> Hello,
> 
> The interrupt stack can be in the __START_KERNEL_map region in which
> virt_to_page will not work. This caused ppp_mppe to crash on CentOS 5 on x86_64
> (http://bugs.centos.org/view.php?id=2076).
> 
> The fix is to avoid copying the interim key. We can simply use it in its
> original place, which is kmalloc'd.

Needs a Signed-off-by: line, but otherwise, looks good, and even saves
some stack space.  Thanks for tracking this down.

-Matt

-- 
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Audio Users]     [Linux for Hams]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Fedora Users]

  Powered by Linux