Re: [patch 08/14] support building pppdump with the system zlib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marco d'Itri writes:

> +ifdef HAVE_ZLIB
> +LIBS += -lz
> +else
> +OBJS += zlib.o
> +endif

Are you sure that the Z_BLOCK value of the flush parameter to inflate
works the same as the Z_PACKET_FLUSH value that I added to zlib.c?
Possibly it does, but there could be differences.  (Note that both
constants have the value 5.)

Also it seems a bit dangerous to build deflate.o against the zlib.h in
pppd but link it against the system zlib, which has a longer z_stream
definition.  If you use the system zlib.h you will hit the
Z_PACKET_FLUSH vs. Z_BLOCK thing of course.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Audio Users]     [Linux for Hams]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Fedora Users]

  Powered by Linux