[patch 02/14] always create a new process group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



pppd sends signals to the whole process group, so it must always create
a new one or it may kill the parent process and its siblings.
Currently setsid() is not called when the updetach option is used.
We want to make the detached and non-detached code paths as similar as
possible.

http://ppp.samba.org/cgi-bin/ppp-bugs/incoming?id=1411
http://ppp.samba.org/cgi-bin/ppp-bugs/incoming?id=1589

--- a/pppd/main.c
+++ b/pppd/main.c
@@ -433,6 +433,13 @@ main(argc, argv)
     }
 
     /*
+     * pppd sends signals to the whole process group, so it must always
+     * create a new one or it may kill the parent process and its siblings.
+     */
+    setsid();
+    chdir("/");
+
+    /*
      * Initialize system-dependent stuff.
      */
     sys_init();
@@ -775,8 +782,6 @@ detach()
 	create_linkpidfile(pid);
 	exit(0);		/* parent dies */
     }
-    setsid();
-    chdir("/");
     dup2(fd_devnull, 0);
     dup2(fd_devnull, 1);
     dup2(fd_devnull, 2);

-- 
ciao,
Marco

-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Audio Users]     [Linux for Hams]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Fedora Users]

  Powered by Linux