-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
Commit eaf140b60ec961252083ab8adaf67aef29a362dd broke my Pinnacle
Remote on the serial port after resuming from disk. I've attached a
trivial fix, though perhaps you rather want to refactor like you did
with freeze/suspend. Bisect is from my custom kernel but should
confirm the problem.
Regards,
Harald
- --
`Experience is the best teacher.'
PGP Key ID: 0xBA3AC516
Fingerprint: 569E 0ADA 440A 8B11 D1A2 AB47 8238 0256 BA3A C516
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJSrkC7AAoJEII4Ala6OsUWm0EIAJ09UEsH1oABzEN0Dxsn04V3
E0SOXjSyBQYflSdFRiMVwOHrE+Hv3sAi8m9QXOUO8Swd6Prg8KFCspI8A2vpFtbb
e+U/7hOKNsoU8FQ2MwZ3troQjz6+uzgoBaL9dk+kgytKq0T7SJkarLrjHc3RhYiz
NO5IhZslbhja0IdF3f8ZMYbfzztyDhqtKvNXt3mT1McfQGatW1S9tr5oopEviICU
/Jt0bM5PlCKK9I9OdgkNh8DydJ6sxRFQXbKsHwsLmu3dN7CiEHTKVM37kwJ1zfYW
3BinZHYXWW6Ya8YqTz3YQhjbt61dboZGS0hA2jTzZswrNCzSfj9stxfDYHlHo7I=
=Oj3U
-----END PGP SIGNATURE-----
>From d27ff2851e3abe5cb48e7bf1cb181107a064dee5 Mon Sep 17 00:00:00 2001
From: Harald Judt <h.judt@xxxxxx>
Date: Mon, 16 Dec 2013 00:33:35 +0100
Subject: PNP: properly resume after hibernation
Commit eaf140b60ec961252083ab8adaf67aef29a362dd converted bus legacy pm_ops
to dev_pm_ops using existing suspend and resume routines. It added the
.freeze field but missed the .restore counterpart, and so broke
hibernate/resume for 8250.
This trivial patch fixes this by simply hooking up the resume function
to the restore field.
Signed-off-by: Harald Judt <h.judt@xxxxxx>
---
drivers/pnp/driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index a39ee38..a953df0 100644
--- a/drivers/pnp/driver.c
+++ b/drivers/pnp/driver.c
@@ -237,6 +237,7 @@ static const struct dev_pm_ops pnp_bus_dev_pm_ops = {
.suspend = pnp_bus_suspend,
.freeze = pnp_bus_freeze,
.resume = pnp_bus_resume,
+ .restore = pnp_bus_resume,
};
struct bus_type pnp_bus_type = {
--
1.8.5.1
git bisect start
# bad: [5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52] Linux 3.12
git bisect bad 5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52
# good: [a2359227afe7e926ed1ca4f79b678abd5d42623a] Merge branch 'upstream-3.11' into tuxonice-3.11
git bisect good a2359227afe7e926ed1ca4f79b678abd5d42623a
# good: [5ee54f38171b9b3541c5e9cf9c3a9e53455fd8b4] Linux 3.11.10
git bisect good 5ee54f38171b9b3541c5e9cf9c3a9e53455fd8b4
# good: [6e4664525b1db28f8c4e1130957f70a94c19213e] Linux 3.11
git bisect good 6e4664525b1db28f8c4e1130957f70a94c19213e
# good: [4004afd5f51ad0a86be405522b1ecf28ba66f4e5] exec/ptrace: fix get_dumpable() incorrect tests
git bisect good 4004afd5f51ad0a86be405522b1ecf28ba66f4e5
# bad: [cc998ff8811530be521f6b316f37ab7676a07938] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect bad cc998ff8811530be521f6b316f37ab7676a07938
# bad: [816434ec4a674fcdb3c2221a6dffdc8f34020550] Merge branch 'x86-spinlocks-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad 816434ec4a674fcdb3c2221a6dffdc8f34020550
# good: [751144271f4b63d5de9005ea4e5e6e5c7c6fd629] Merge tag 'staging-3.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
git bisect good 751144271f4b63d5de9005ea4e5e6e5c7c6fd629
# bad: [40031da445fb4d269af9c7c445b2adf674f171e7] Merge tag 'pm+acpi-3.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
git bisect bad 40031da445fb4d269af9c7c445b2adf674f171e7
# good: [f66c83d059d1ed90968caa81d401f160912b063a] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
git bisect good f66c83d059d1ed90968caa81d401f160912b063a
# bad: [ce63e1862ce81d85df9e3239e4467ac765e04962] Merge branch 'pnp'
git bisect bad ce63e1862ce81d85df9e3239e4467ac765e04962
# good: [0ad4c9a9848fdd46dc422160efd947489a98bbc1] Merge branch 'acpi-pm'
git bisect good 0ad4c9a9848fdd46dc422160efd947489a98bbc1
# good: [afdca01c9821134e71011029a194dd8fcb88c97e] Merge branch 'acpica'
git bisect good afdca01c9821134e71011029a194dd8fcb88c97e
# good: [0c581415b522267138d807814e526aa7534b9a61] Merge branch 'acpi-assorted'
git bisect good 0c581415b522267138d807814e526aa7534b9a61
# good: [8462d9df9d5033da4d25e59016b1e7a9d94a1f22] Merge branch 'acpi-bind'
git bisect good 8462d9df9d5033da4d25e59016b1e7a9d94a1f22
# good: [94fb9823a7c478bf88b99b8da4fc3e540608ece5] ACPI: blacklist win8 OSI for buggy laptops
git bisect good 94fb9823a7c478bf88b99b8da4fc3e540608ece5
# good: [551f5c74e17ba9257cdc35bf657ee448cad2d5b0] Merge branch 'acpi-processor'
git bisect good 551f5c74e17ba9257cdc35bf657ee448cad2d5b0
# bad: [eaf140b60ec961252083ab8adaf67aef29a362dd] PNP: convert PNP driver bus legacy pm_ops to dev_pm_ops
git bisect bad eaf140b60ec961252083ab8adaf67aef29a362dd
# first bad commit: [eaf140b60ec961252083ab8adaf67aef29a362dd] PNP: convert PNP driver bus legacy pm_ops to dev_pm_ops
