On Thu, 1 Aug 2013, Oliver Neukum wrote: > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > More importantly, if we already know that the medium is not present or > > has been changed since it was last used, then there's no reason to call > > sd_sync_cache() at all. > > Like this? Yes, I like this a lot better, except I would put the test for !sdkp->media_present in sd_suspend_common() -- no need to print the "Synchronizing SCSI Cache" message if you're not going to go through with it. What do the SCSI people think? Alan Stern