Re: [PATCH] irqchip: irqc: Add runtime PM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

> On Thu, Apr 04, 2013 at 03:21:06PM +0900, Simon Horman wrote:
> > This was tested using the SMSC LAN on the APE6EVM board.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> 
> Magnus, Morimoto-san, could you review this?

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

> 
> > ---
> >  drivers/irqchip/irq-renesas-irqc.c |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
> > index 927bff3..649cd69 100644
> > --- a/drivers/irqchip/irq-renesas-irqc.c
> > +++ b/drivers/irqchip/irq-renesas-irqc.c
> > @@ -19,6 +19,7 @@
> >  
> >  #include <linux/init.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> >  #include <linux/spinlock.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/ioport.h>
> > @@ -181,6 +182,9 @@ static int irqc_probe(struct platform_device *pdev)
> >  		goto err1;
> >  	}
> >  
> > +	pm_runtime_enable(&pdev->dev);
> > +	pm_runtime_get_sync(&pdev->dev);
> > +
> >  	/* allow any number of IRQs between 1 and IRQC_IRQ_MAX */
> >  	for (k = 0; k < IRQC_IRQ_MAX; k++) {
> >  		irq = platform_get_resource(pdev, IORESOURCE_IRQ, k);
> > @@ -255,6 +259,8 @@ err3:
> >  err2:
> >  	iounmap(p->iomem);
> >  err1:
> > +	pm_runtime_put_sync(&pdev->dev);
> > +	pm_runtime_disable(&pdev->dev);
> >  	kfree(p);
> >  err0:
> >  	return ret;
> > @@ -270,6 +276,8 @@ static int irqc_remove(struct platform_device *pdev)
> >  
> >  	irq_domain_remove(p->irq_domain);
> >  	iounmap(p->iomem);
> > +	pm_runtime_put_sync(&pdev->dev);
> > +	pm_runtime_disable(&pdev->dev);
> >  	kfree(p);
> >  	return 0;
> >  }
> > -- 
> > 1.7.10.4
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Best regards
---
Kuninori Morimoto




[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux