Re: [PATCH] irqchip: irqc: Add runtime PM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Fri, Apr 5, 2013 at 11:26 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Thu, Apr 04, 2013 at 03:21:06PM +0900, Simon Horman wrote:
>> This was tested using the SMSC LAN on the APE6EVM board.
>>
>> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>
> Magnus, Morimoto-san, could you review this?

Thanks for working on Runtime PM for the IRQC driver, this code looks
fine to me. In the future we probably want to try control the usage
count based on enable()/disable() callbacks in a more fine grained
fashion, but I wonder how much that would actually help us since I
don't think we can turn off the power domain where IRQC is located
anyway.

Simon, please remember to also merge your code for IRQC MSTP bit
control on r8a73a4 and/or r8a7790. Without that I can't really see how
Runtime PM can control any actual hardware.

Thanks,

/ magnus




[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux