On Sat, Oct 27, 2012 at 01:09:36PM -0700, Brian Norris wrote: > AHCI platform devices may provide an exit() routine, via > ahci_platform_data, that powers off the SATA core. Such a routine should > be executed from the ata_port_operations host_stop() hook. That way, the > ATA subsystem can perform any last-minute hardware cleanup (via devres, > for example), then trigger the power-off at the appropriate time. > > This patch fixes bus errors triggered during module removal or device > unbinding, seen on an SoC SATA core. > > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> For all three patches, Acked-by: Tejun Heo <tj@xxxxxxxxxx> If you have some time, it would be nice to introduce ata_platform_remove_one(). There's no reason to have that implemented separately in each driver. It would also be nice to move remove_one()'s to some higher level port_ops so that individual drivers don't have to specify them explicitly. Thanks. -- tejun
