On Mon, Oct 01, 2012 at 01:56:17PM +0000, Zhang, Rui wrote: > > > > -----Original Message----- > > From: Mika Westerberg [mailto:mika.westerberg@xxxxxxxxxxxxxxx] > > Sent: Monday, October 01, 2012 2:38 PM > > To: Zhang, Rui > > Cc: LKML; linux-pm; linux-i2c; linux-acpi@xxxxxxxxxxxxxxx; Len, Brown; > > Rafael J. Wysocki; Grant Likely; Dirk Brandewie > > Subject: Re: [RFC PATCH 1/6] Introduce acpi_match_device_id(). > > Importance: High > > > > On Sat, Sep 29, 2012 at 01:31:52PM +0000, Zhang, Rui wrote: > > > > > > > > +{ > > > > > + acpi_handle handle = DEVICE_ACPI_HANDLE(dev); > > > > > > > > If the device is not bound to an ACPI handle this will return NULL. > > > > And I don't see you doing that in this series meaning that.. > > > > > > > > > > > > > You're right, I should set pdev->archdata.acpi_handle to the I2C > > > controller in i2c_root.c. > > > > There already is an API for that - check drivers/acpi/glue.c. > > Do you mean acpi_bind? No, I mean register_acpi_bus_type(). You can see an example of this looking PCI, USB, .., drivers.
