On Wed, Jun 13, 2012 at 10:04:43PM +0200, Rafael J. Wysocki wrote: > On Wednesday, June 13, 2012, Greg KH wrote: > > On Wed, Jun 13, 2012 at 11:20:19AM -0400, Alan Stern wrote: > > > This patch (as1558) fixes a problem affecting several ASUS computers: > > > The machine crashes or corrupts memory when going into suspend if the > > > ehci-hcd driver is bound to any controllers. Users have been forced > > > to unbind or unload ehci-hcd before putting their systems to sleep. > > > > > > After extensive testing, it was determined that the machines don't > > > like going into suspend when any EHCI controllers are in the PCI D3 > > > power state. Presumably this is a firmware bug, but there's nothing > > > we can do about it except to avoid putting the controllers in D3 > > > during system sleep. > > > > > > The patch adds a new flag to indicate whether the problem is present, > > > and avoids changing the controller's power state if the flag is set. > > > Runtime suspend is unaffected; this matters only for system suspend. > > > However as a side effect, the controller will not respond to remote > > > wakeup requests while the system is asleep. Hence USB wakeup is not > > > functional -- but of course, this is already true in the current state > > > of affairs. > > > > > > A similar patch has already been applied as commit > > > 151b61284776be2d6f02d48c23c3625678960b97 (USB: EHCI: fix crash during > > > suspend on ASUS computers). The patch supersedes that one and reverts > > > it. There are two differences: > > > > > > The old patch added the flag at the USB level; this patch > > > adds it at the PCI level. > > > > > > The old patch applied to all chipsets with the same vendor, > > > subsystem vendor, and product IDs; this patch makes an > > > exception for a known-good system (based on DMI information). > > > > > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > > Tested-by: Dâniel Fraga <fragabr@xxxxxxxxx> > > > Tested-by: Andrey Rahmatullin <wrar@xxxxxxxxx> > > > Tested-by: Steven Rostedt <rostedt@xxxxxxxxxxx> > > > CC: Greg KH <greg@xxxxxxxxx> > > > CC: <stable@xxxxxxxxxxxxxxx> > > > > > > --- > > > > > > Greg, do you mind if this goes in through Rafael's tree? > > > > Not at all, but I can also take it. > > > > Rafael, if you want to take it, please add: > > > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > to it, or let me know, and I can take this through my tree. > > Please take it, if that's not a problem, I don't have any other > patches for 3.5 pending. And please add: > > Reviewed-by: Rafael J. Wysocki <rjw@xxxxxxx> Ok, I'll go queue it up right now. greg k-h
