On 09/05, Tejun Heo wrote: > > On Sun, Sep 04, 2011 at 08:02:06PM +0200, Oleg Nesterov wrote: > > Cough. Now it doesn't look right to me ;) > > > > If the user write "FROZEN" into the control file, we should not > > turn the CGROUP_FROZEN state into CGROUP_FREEZING. Probably this > > is harmless, but this looks wrong and this doesn't match the > > current behaviour, user-visible change. > > It's not user-visible as the state is always updated before shown to > userland. Ah, indeed, thanks. OK. So, the only proble I can see is that update_if_frozen() can hit BUG_ON(nfrozen > 0), but this is off-topic. I think this patch is correct. Oleg. _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm