On 09/01, Matt Helsley wrote:
>
> On Wed, Aug 31, 2011 at 12:21:07PM +0200, Tejun Heo wrote:
> > case CGROUP_FROZEN:
> > - atomic_inc(&system_freezing_cnt);
> > - retval = try_to_freeze_cgroup(cgroup, freezer);
> > + if (freezer->state == CGROUP_THAWED) {
> > + freezer->state = CGROUP_FREEZING;
> > + atomic_inc(&system_freezing_cnt);
> > + retval = try_to_freeze_cgroup(cgroup, freezer);
>
> This still doesn't look quite right. If the cgroup is FREEZING it should
> also call try_to_freeze_cgroup(). I think this is what's needed:
>
> if (freezer->state == CGROUP_THAWED)
> atomic_inc(&system_freezing_cnt);
> freezer->state = CGROUP_FREEZING;
> retval = try_to_freeze_cgroup(cgroup, freezer);
This is what I mentioned before, to me this looks like a win.
Why do we need try_to_freeze_cgroup() in this case? "for safety"
could actually mean "hide the bug" ;)
But I agree either way. Rafael, I think 1-4 are fine, but I think
we need the simple 5/4, will send in a minute...
Oleg.
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
