Re: [PATCH 1/3] bq24022: Evaluate returns of gpio_direction_output-calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 28, 2011 at 03:08:30PM +0200, Heiko Stübner wrote:

>  	ret = gpio_direction_output(pdata->gpio_iset2, 0);
> +	if (ret) {
> +		dev_dbg(&pdev->dev, "couldn't set ISET2 GPIO: %d\n",
> +			pdata->gpio_iset2);
> +		goto err_reg;
> +	}
>  	ret = gpio_direction_output(pdata->gpio_nce, 1);
> +	if (ret) {
> +		dev_dbg(&pdev->dev, "couldn't set nCE GPIO: %d\n",
> +			pdata->gpio_nce);
> +		goto err_reg;
> +	}

If these are fatal errors the log messages shouldn't be dev_dbg() but
should instead be something that will be displayed by default.
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm



[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux