On Tue, Aug 23, 2011 at 3:19 PM, Tejun Heo <tj@xxxxxxxxxx> wrote: > Currently, there's no way to pass multiple tasks to cgroup_subsys > methods necessitating the need for separate per-process and per-task > methods. This patch introduces cgroup_taskset which can be used to > pass multiple tasks and their associated cgroups to cgroup_subsys > methods. > > Three methods - can_attach(), cancel_attach() and attach() - are > converted to use cgroup_taskset. This unifies passed parameters so > that all methods have access to all information. Conversions in this > patchset are identical and don't introduce any behavior change. > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> The general idea of passing consistent information to all *attach methods seems good, but isn't it simpler to just fix up the various method signatures? The whole point of having *attach() and *attach_task() was to minimize the amount of boilerplate (in this case, iterating across a new cgroup_taskset abstraction) in the subsystems, leaving that to the cgroups framework. Paul _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
