> On Thursday, August 04, 2011, Greg KH wrote: > > On Thu, Aug 04, 2011 at 01:13:38PM +0800, Liu, ShuoX wrote: > > > >From a906b0b5b4ff3414ceb9fc7a69a3d7c9d66e46b1 Mon Sep 17 > 00:00:00 2001 > > > From: ShuoX Liu <shuox.liu@xxxxxxxxx> > > > Date: Thu, 28 Jul 2011 10:54:22 +0800 > > > Subject: [PATCH] PM: add statistics sysfs file for suspend to ram. > > > > What's this stuff here for? That's not needed (hint, I would have to > > edit it out by hand to be able to apply this patch.) > > > > Thanks for resending a version that passes checkpatch.pl and could be > > applied, but all of my previous comments still stand. This patch, as > > is, is totally unacceptable. > > Agreed, plus I'd like to know the motivation behind it. That is, we have > quite a few debug facilities in that code, so why are they insufficient? Some explanation from Yanmin, "We are enabling power features on Medfield. Some testers and developers complain they don't know if system tries suspend-2-ram, and what device fails to suspend. They need such info for a quick check. If turning on CONFIG_PM_DEBUG, we get too much info and testers need recompile the system. The patch records the suspend-2-ram fail/success statistics and the last 2 failed devices. Users could find what device causes the failure quickly." If you guys agree, I will modify the patch as Greg said and resend. Shuo _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
