On Mon, May 23, 2011 at 11:01:32AM +0100, Dave Martin wrote: > On Fri, May 20, 2011 at 07:05:10PM +0100, Russell King - ARM Linux wrote: > > Out of the list you mention above, the only thing which isn't saved are the > > FIQ registers, and that's a problem for S2RAM too, and should be done by > > arch/arm/kernel/fiq.c hooking into the suspend paths. > > The alternative view is that the driver using FIQ owns the state in the FIQ > mode registers and is therefore responsible for saving and restoring it > across suspend/resume. If so, then any additional globally implemented > state save/restore of the FIQ mode state is unnecessary. This seems to be most sensible - if the FIQ is being used as a software-DMA, then the hardware side of that needs to be cleanly shutdown (eg, waiting for the DMA to complete before proceeding) to ensure no loss of data. That can't happen from within the FIQ code. I also wonder about issues of secure/non-secure stuff here too - what that means is that if we have a driver using FIQ mode, then we have FIQ state to save, but if not there's probably no point (or even any way) to save that state ourselves anyway. _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
