On 04/28/2011 12:36 PM, Rafael J. Wysocki wrote:
> +/**
> + * pm_runtime_clk_add - Start using a device clock for runtime PM.
> + * @dev: Device whose clock is going to be used for runtime PM.
> + * @con_id: Connection ID of the clock.
> + *
> + * Add the clock represented by @con_id to the list of clocks used for
> + * the runtime PM of @dev.
> + */
> +int pm_runtime_clk_add(struct device *dev, const char *con_id)
> +{
> + struct pm_runtime_clk_data *prd = __to_prd(dev);
> + struct pm_clock_entry *ce;
> +
> + if (!prd)
> + return -EINVAL;
> +
> + ce = kzalloc(sizeof(*ce), GFP_KERNEL);
> + if (!ce) {
> + dev_err(dev, "Not enough memory for clock entry.\n");
> + return -ENOMEM;
> + }
> +
> + if (con_id) {
> + ce->con_id = kstrdup(con_id, GFP_KERNEL);
> + if (!ce->con_id) {
> + dev_err(dev,
> + "Not enough memory for clock conection ID.\n");
Missing an 'n' in connection.
> + kfree(ce);
> + return -ENOMEM;
> + }
> + }
> +
> + mutex_lock(&prd->lock);
> + list_add_tail(&ce->node, &prd->clock_list);
> + mutex_unlock(&prd->lock);
> + return 0;
> +}
> +
> +/**
> + * __pm_runtime_clk_remove - Destroy runtime PM clock entry.
> + * @ce: Runtime PM clock entry to destroy.
> + *
> + * This routine must be called under the mutex protecting the runtime PM list
> + * of clocks corresponding the the @ce's device.
> + */
> +static void __pm_runtime_clk_remove(struct pm_clock_entry *ce)
> +{
> + if (!ce)
> + return;
> +
> + list_del(&ce->node);
> +
> + if (!IS_ERR_OR_NULL(ce->clk)) {
NULL is a valid clock so you'll need to figure out some way to handle
that throughout this code.
> + if (ce->clock_enabled)
> + clk_disable(ce->clk);
> +
> + clk_put(ce->clk);
> + }
> +
> + if (ce->con_id)
> + kfree(ce->con_id);
> +
> + kfree(ce);
> +}
> +
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
