On Sunday, March 13, 2011, Thomas Gleixner wrote:
> On Sat, 12 Mar 2011, Rafael J. Wysocki wrote:
> > -static int lapic_resume(struct sys_device *dev)
> > +static void lapic_resume(void)
> > {
> > unsigned int l, h;
> > unsigned long flags;
> > @@ -2083,7 +2083,7 @@ static int lapic_resume(struct sys_devic
> > struct IO_APIC_route_entry **ioapic_entries = NULL;
> >
> > if (!apic_pm_state.active)
> > - return 0;
> > + return;
> >
> > local_irq_save(flags);
>
> That want's the following on top:
>
> @@ -2079,8 +2079,7 @@ static void lapic_resume(void)
> {
> unsigned int l, h;
> unsigned long flags;
> - int maxlvt;
> - int ret = 0;
> + int maxlvt, ret;
> struct IO_APIC_route_entry **ioapic_entries = NULL;
>
> if (!apic_pm_state.active)
> @@ -2091,7 +2090,6 @@ static void lapic_resume(void)
> ioapic_entries = alloc_ioapic_entries();
> if (!ioapic_entries) {
> WARN(1, "Alloc ioapic_entries in lapic resume failed.");
> - ret = -ENOMEM;
> goto restore;
> }
Right, I'll fold it into the final version of the patch.
> Otherwise, Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Thanks!
Rafael
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
