On Wednesday, March 02, 2011, Pierre Tardy wrote: > On Tue, Mar 1, 2011 at 10:07 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > > On Tuesday, March 01, 2011, Pierre Tardy wrote: > >> On Tue, Mar 1, 2011 at 8:33 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > >> > On Tue, 1 Mar 2011, Pierre Tardy wrote: > >> > > >> >> Please find sdhci runtime_pm implementation. > >> >> > >> >> It uses clock gating fw as a tip to know when our chip is idle. > >> >> It implements wake up from card insertion/removal. > >> >> > >> >> This is RFC, please dont merge yet. I really would like to have deep review > >> >> from PCI linux-pm guys. > >> >> > >> >> Opens are: > >> >> > >> >> 1/ Not sure if the pci configs in the driver in rpm_suspend/resume flow > >> >> are not duplicate from what the core is doing. > >> > > >> > There may be one or two small errors. > >> > > >> >> 2/ Wakeup from D3hot: I cannot find any driver that is implementing it in current upstream, > >> > > >> > Other drivers do it, but they use PCI PME# instead of interrupts. > >> Could you please elaborate? > >> My understanding is that PCI PME will generate MSI, which translate in > >> interrupt. > > > > Your driver won't get those interrupts. > > > > How it works is, basically, that when the device signals wakeup, it either > > causes a PME# signal to be raised (parallel PCI), or a PME Message to be > > sent upstream (PCIe). In the first case it will cause a platform event > > (eg. ACPI GPE) to occur and the handle of that event will resume your > > device (using pm_request_resume()). In the second case it will cause the PCIe > > root port handling the PME Message to generate an interrupt and the handler of > > that interrupt will resume your device. > Thanks, that explain a lot how it works. > What I still dont understand is that the wake source I'll have (e.g. > sd card insert) is still an interrupt source. > So it is supposed to generate interrupt until the interrupt source is > acknowledged. > Are we supposed to mask that interrupt source while suspended to make > sure we have either wake or interrupt? I think the interrupt should be masked while suspended and the driver's resume routine should unmask it. Thanks, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
