On Thu, Feb 17, 2011 at 23:14, Takashi Iwai <tiwai@xxxxxxx> wrote: > At Thu, 17 Feb 2011 13:19:46 +0530, > Rabin Vincent wrote: >> >> Support pm_ops in the AMBA bus instead of the legacy ops. pm_ops is needed >> for runtime pm, and there is also a general move to convert drivers to >> dev_pm_ops rather than bus specific PM ops in order to facilitate core >> development. >> >> Since there are only 6 AMBA drivers using suspend/resume, convert them all in >> one go and directly use the GENERIC_SUBSYS_PM_OPS in the bus. >> >> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> >> Cc: Chris Ball <cjb@xxxxxxxxxx> >> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> >> Cc: Takashi Iwai <tiwai@xxxxxxx> >> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx> >> Signed-off-by: Rabin Vincent <rabin.vincent@xxxxxxxxxxxxxx> > > For sound/arm/aaci.c, > > Acked-by: Takashi Iwai <tiwai@xxxxxxx> > > Though, this would result in a zero-filled *_pm struct when > CONFIG_PM_* isn't set? It's a few bytes wastes ;) Thank you for the ack. However, in v2 of the patch I've done a different implementation in the bus code that doesn't necessitate the conversion of all the drivers together, so this part is dropped. I will take this comment into consideration if I do end up converting all the drivers. Thanks. _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm