On Sun, 26 Dec 2010 19:44:32 +0100 "Rafael J. Wysocki" <rjw@xxxxxxx> wrote: > From: Rafael J. Wysocki <rjw@xxxxxxx> > > The sky2 driver uses the legacy PCI power management, so it has to do > some PCI-specific things in its ->suspend() and ->resume() callbacks, > which isn't necessary and should better be done by the PCI > sybsystem-level power management code. Moreover, it uses > device_set_wakeup_enable() incorrectly (that function should be > used when the WoL setting is changed rather than during suspend). > > Convert sky2 to the new PCI power management framework and make it > let the PCI subsystem take care of all the PCI-specific aspects of > device handling during system power transitions. > > Tested on a desktop machine with a Marvell 88E8056 PCI-E adapter. > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> Tested on 88E8055 (laptop), my desktop machines have video issues and won't suspend/resume. Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx> _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
