Re: Wrong commit in the ACPI release branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, December 13, 2010, Jan Beulich wrote:
> >>> On 11.12.10 at 23:29, "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> > The following commit:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h 
> > =091aad6af4ab29af693ced5d6970ceee9d5981c8
> > 
> > (ACPI: eliminate unused variable warning for !ACPI_SLEEP)
> > is actually wrong, because it's going to break compilation for
> > (!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).
> 
> How would this break compilation in *any* configuration? The
> variable definition got moved into an #ifdef the #else of which
> has
> 
> #define acpi_target_sleep_state	ACPI_STATE_S0

OK, I seem to haven't looked at the patch carefully enough, sorry for the
noise.

Rafael
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux