On Tuesday, October 05, 2010, Rafael J. Wysocki wrote:
> On Friday, October 01, 2010, Nishanth Menon wrote:
...
> > +int opp_init_cpufreq_table(struct device *dev,
> > + struct cpufreq_frequency_table **table)
> > +{
> > + struct device_opp *dev_opp;
> > + struct opp *opp;
> > + struct cpufreq_frequency_table *freq_table;
> > + int i = 0;
> > +
> > + rcu_read_lock();
>
> I would pretend I'm an updater here and acquire dev_opp_list_lock instead.
>
> > + dev_opp = find_device_opp(dev);
> > + if (IS_ERR(dev_opp)) {
> > + rcu_read_unlock();
>
> So that won't be necessary.
Or rather the lock will have to be dropped here instead.
> > + pr_warning("Unable to find device\n");
> > + return PTR_ERR(dev_opp);
> > + }
> > +
Thanks,
Rafael
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
