On Sat, 2 Oct 2010, Rafael J. Wysocki wrote: > > > > BTW, I like some changes made by your patch that aren't really related to > > > > the issue at hand, so I think the patch below can be applied regardless of > > > > the other changes, unless I made a mistake I can see now. > > > > > > It looks like a good change, but you forgot to preserve the assignments > > > to dev->power.runtime_error. > > > > That's correct and there's a difference betwee _idle and the other cases > > because of that. I'll send updated patch with a changelog shortly. > > Appended as promised. This looks okay. In principle you could tell rpm_callback whether or not to store the return value in dev->power.runtime_error (by passing an extra argument), but it's probably not worthwhile. Alan Stern _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
