Re: [PATCH 1/2] PERF(kernel): Cleanup power events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-10-01 at 08:51 -0700, Arjan van de Ven wrote:
> On 10/1/2010 8:04 AM, Thomas Renninger wrote:
> > New power trace events:
> > power:processor_idle
> > power:processor_frequency
> > power:machine_suspend
> >
> >
> > C-state/idle accounting events:
> >    power:power_start
> >    power:power_end
> > are replaced with:
> >    power:processor_idle
> >
> > and
> >    power:power_frequency
> > is replaced with:
> >    power:processor_frequency
> >
> > power:machine_suspend
> > is newly introduced, a first implementation
> > comes from the ARM side, but it's easy to add these events
> > in X86 as well if needed.
> >
> > the type= field got removed from both, it was never
> > used and the type is differed by the event type itself.
> >
> > perf timechart
> > userspace tool gets adjusted in a separate patch.
> >
> > Signed-off-by: Thomas Renninger<trenn@xxxxxxx>
> > CC: Jean Pihet<jean.pihet@xxxxxxxxxxxxxx>
> > CC: Arjan van de Ven<arjan@xxxxxxxxxxxxxxx>
> 
> 
> As before, strong NACK from me before, this is an ABI break.

What ABI is broken? Trace points have not been declared an ABI. They
expose too much of the internals of the system to be considered one. Any
tool that can not cope with a tracepoint change is fundamentally broken.

-- Steve


_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux