Re: [PATCH] PM: add synchronous runtime interface for interrupt handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 1 Oct 2010, Rafael J. Wysocki wrote:

> On Thursday, September 30, 2010, Alan Stern wrote:
> > This patch (as1431) adds a synchronous runtime-PM interface suitable
> > for use in interrupt handlers.  Four new helper functions are defined:
> > 
> > 	pm_runtime_suspend_irq(), pm_runtime_resume_irq(),
> > 	pm_runtime_get_sync_irq(), pm_runtime_put_sync_irq(),
> > 
> > together with pm_runtime_callbacks_in_irq(), which subsystems use to
> > tell the PM core that the runtime callbacks should be invoked with
> > interrupts disabled.
> 
> BTW, I like some changes made by your patch that aren't really related to
> the issue at hand, so I think the patch below can be applied regardless of
> the other changes, unless I made a mistake I can see now.

It looks like a good change, but you forgot to preserve the assignments 
to dev->power.runtime_error.

Alan Stern


_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux