Hello, > > > > Like in the patch below, perhaps? > > > > > > Looks like fine. but I have one question. hibernate_preallocate_memory() call > > > preallocate_image_memory() two times. Why do you only care latter one? > > > former one seems similar risk. > > > > The first one is mandatory, ie. if we can't allocate the requested number of > > pages at this point, we fail the entire hibernation. In that case the > > performance hit doesn't matter. > > IOW, your patch at http://lkml.org/lkml/2010/9/2/262 is still necessary to > protect against the infinite loop in that case. As far as I understand, we need distinguish two allocation failure. 1) failure because no enough memory -> yes, hibernation should fail 2) failure because already allocated enough lower zone memory -> why should we fail? If the system has a lot of memory, scenario (2) is happen frequently than (1). I think we need check alloc_highmem and alloc_normal variable and call preallocate_image_highmem() again instead preallocate_image_memory() if we've alread allocated enough lots normal memory. nit? _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
