Your right. :( Its working by luck, GFP_KERNEL (= 0x10|0x40|0x80 = 0xD0 = 208 ) is not too big and not too small. acked-by: mark gross <markgross@xxxxxxxxxxx> --mark >-----Original Message----- >From: Dr. David Alan Gilbert [mailto:linux@xxxxxxxxxxx] >Sent: Sunday, August 22, 2010 7:36 AM >To: linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx >Cc: James.Bottomley@xxxxxxx; Gross, Mark >Subject: [PATCH] kzalloc params swapped in pm_qos_power_open > >Hi, > I was playing with sparse and it looks like it spotted that >the kzalloc in pm_qos_power_open in the current Linus's git tree >seems to have its parameters swapped. I've got a patch below, >I've only build tested it. > >Signed-off-by: David Alan Gilbert <linux@xxxxxxxxxxx> >--- >**BUILD TESTED ONLY** (against current git) > >diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c >index 996a4de..71dcc21 100644 >--- a/kernel/pm_qos_params.c >+++ b/kernel/pm_qos_params.c >@@ -348,7 +348,7 @@ static int pm_qos_power_open(struct inode *inode, >struct file *filp) > > pm_qos_class = find_pm_qos_object_by_minor(iminor(inode)); > if (pm_qos_class >= 0) { >- struct pm_qos_request_list *req = kzalloc(GFP_KERNEL, >sizeof(*req)); >+ struct pm_qos_request_list *req = kzalloc(sizeof(*req), >GFP_KERNEL); > if (!req) > return -ENOMEM; > > >-- > -----Open up your eyes, open up your mind, open up your code ------- >/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \ >\ gro.gilbert @ treblig.org | | In Hex / > \ _________________________|_____ http://www.treblig.org |_______/ _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
