On Fri, Jun 4, 2010 at 1:34 AM, Ingo Molnar <mingo@xxxxxxx> wrote: > > * Arve Hj?nnev?g <arve@xxxxxxxxxxx> wrote: > >> > [...] >> > >> > Why do you need to track input wakeups? It's rather fragile and rather >> > unnecessary [...] >> >> Because we have keys that should always turn the screen on, but the problem >> is not specific to input events. If we enabled a wakeup event it usually >> means we need this event to always work, not just when the system is fully >> awake or fully suspended. > > Hm, i cannot follow that generic claim. Could you please point out the problem > to me via a specific example? Which task does what, what undesirable thing > happens where, etc. > We have many wakeup events, and some of them are invisible to the user. For instance on the Nexus One wake up every 10 minutes monitor the battery health. If the user presses a key right after this work has finished and we did not block suspend until userspace could process this key event, we risk suspending before we could turn the screen on, which to the user looks like the key did not work. Another example, the user pressed the power key which turns the screen off and allows suspend. We initiate suspend and a phone call comes in. If we don't block suspend until we processed the incoming phone call notification, the phone may never ring (some devices will send a new message every few seconds for this, so on those devices it would just delay the ringing). -- Arve Hjønnevåg _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
