2010/4/28 Rafael J. Wysocki <rjw@xxxxxxx>: > On Wednesday 28 April 2010, Arve Hjønnevåg wrote: >> Add a misc device, "suspend_blocker", that allows user-space processes >> to block auto suspend. The device has ioctls to create a suspend_blocker, >> and to block and unblock suspend. To delete the suspend_blocker, close >> the device. >> >> Signed-off-by: Arve Hjønnevåg <arve@xxxxxxxxxxx> > ... >> + >> +#include <linux/fs.h> >> +#include <linux/miscdevice.h> >> +#include <linux/module.h> >> +#include <linux/uaccess.h> >> +#include <linux/slab.h> >> +#include <linux/suspend_blocker.h> >> +#include <linux/suspend_block_dev.h> >> + >> +enum { >> + DEBUG_FAILURE = BIT(0), >> +}; >> +static int debug_mask = DEBUG_FAILURE; > > What's the exact purpose of this? To show errors returned to user space. I can turn it off by default if you want. > >> +module_param_named(debug_mask, debug_mask, int, S_IRUGO | S_IWUSR | S_IWGRP); >> + >> +static DEFINE_MUTEX(ioctl_lock); >> + >> +struct user_suspend_blocker { >> + struct suspend_blocker blocker; >> + char name[0]; >> +}; > > Why is this not in a header? It's private to this file. > > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Arve Hjønnevåg _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm