Hi! > > My thought exactly. This is the only approach that also solves the > > following race: > > > > A driver is unloaded at the same time as a suspend starts. > > > > The writeback thread gets frozen. > > > > Then before the rmmod thread is frozen, it calls del_gendisk. > > > > Delaying things by means of a workqueue (or the equivalent) might also > > work, but it doesn't seem as safe. For example, some important > > writebacks might end up getting delayed until too late. Delaying writebacks during sleep should be ok... That's why we do sync() after userspace is frozen -- nothing really important should be waiting for writeback after that point. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
