On Tuesday 02 March 2010 01:13:30 pm Alan Stern wrote: > On Tue, 23 Feb 2010, Dmitry Torokhov wrote: > > > Yes, I agree, we need a genric mechanism for PNP to emable wakups. It > > was discussed a bit here: > > > > http://bugzilla.kernel.org/show_bug.cgi?id=8286 > > > > but David was too hung up on the fact that number of devices in ACPI > > does not map directly onto number of serio ports when i8042 is in active > > multiplexing mode that it id not go anywhere. > > Does this look reasonable? I don't know anything about PNPBIOS or > ISAPNP, so it handles only PNPACPI. But at least it's a starting > point -- and it does enable my system to wake up in response to > hitting a key. I don't know much about power management, but your patch looks reasonable to me. > --- usb-2.6.orig/drivers/pnp/pnpacpi/core.c > +++ usb-2.6/drivers/pnp/pnpacpi/core.c > @@ -121,12 +121,27 @@ static int pnpacpi_disable_resources(str > } > > #ifdef CONFIG_ACPI_SLEEP > +static bool pnpacpi_can_wakeup(struct pnp_dev *dev) > +{ > + acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev); I would have used: struct acpi_device *acpi_dev = dev->data; acpi_handle handle = acpi_dev->handle; here because that's what the rest of the PNPACPI code does. Bjorn _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
