Re: [PATCH 1/1] PM: Add arch_suspend_disable_nonboot_cpus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > (Please wrap at column 80)
> > 
> > This patch is already way better than the original one, but... Why do
> > you want enable/disable_nonboot_cpus to be noped out?
> 
> Today for PPC_PSERIES, PM_SLEEP_SMP is never defined, so for all the
> current code paths that call enable/disable_nonboot_cpus (power off,
> kexec), these functions are noops. I don't want to change that
> behavior.

Why not?

> I figured I can just use the prepare_late and wake pm functions to do
> the work I need to do. Let me know if you think this is a reasonable
> approach and I'll be happy to resend the patch with an appropriate
> subject line and description.

No, I do not think that's reasonable approach. Please just implement
enable/disable_nonboot_cpus; that's the clean fix.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux