On Tuesday 08 December 2009, Alan Stern wrote: > On Tue, 8 Dec 2009, Rafael J. Wysocki wrote: > > > BTW, is there a good reason why completion_done() doesn't use spin_lock_irqsave > > and spin_unlock_irqrestore? complete() and complete_all() use them, so why not > > here? > > And likewise in try_wait_for_completion(). It looks like a bug. Maybe > these routines were not intended to be called with interrupts disabled, > but that requirement doesn't seem to be documented. And it isn't a > natural requirement anyway. OK, let's ask Ingo about that. Ingo, is there any particular reason why completion_done() and try_wait_for_completion() don't use spin_lock_irqsave() and spin_unlock_irqrestore()? Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
