On Tue, 8 Dec 2009, Linus Torvalds wrote: > On Tue, 8 Dec 2009, Alan Stern wrote: > > > > That's not the way it should be done. Linus had children taking their > > parents' locks during suspend, which is simple but leads to > > difficulties. > > No it doesn't. Name them. Really. Let me put this simply: I've told you guys how to do it simply, with _zero_ crap. No "iterating over children". No games. No data structures. No new infrastructure. Just a single new rwlock per device, and _trivial_ code. So here's the challenge: try it my simple way first. I've quoted the code about five million times already. If you _actually_ see some problems, explain them. Don't make up stupid "iterate over each child" things. Don't claim totally made-up "leads to difficulties". Don't make it any more complicated than it needs to be. Keep it simple. And once you have tried that simple approach, and you really can show why it doesn't work, THEN you can try something else. But before you try the simple approach and explain why it wouldn't work, I simply will not pull anything more complex. Understood and agreed? Linus _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
