On Sat 2009-10-10 13:51:45, Jiri Slaby wrote: > There are too many retval variables in save_image. Thus error return > value from snapshot_read_next may be ignored and only part of the > snapshot (successfully) written. > > Remove 'error' variable, invert the condition in the do-while loop > and convert the loop to use only 'ret' variable. > > Switch the rest of the function to consider only 'ret'. > > Also make sure we end printed line by \n if an error occurs. > > Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx> ACK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm