On Monday 05 October 2009, Joe Perches wrote: > On Mon, 2009-10-05 at 21:43 +0200, Rafael J. Wysocki wrote: > > On Monday 05 October 2009, Joe Perches wrote: > > > Added #define pr_fmt(fmt) "PM: " fmt > > > Converted printk(KERN_<level> to pr_<level>( > > > Removed "PM: " prefix > > > Added pr_fmt() to __initdata strings > > > > Well, can you please tell me what actually is wrong with the current code? > > Not much. There were a couple of trivial corrections, > but perhaps the changes add a bit more flexibility and > regularity. > > Effective trivial changes: > > o Added KERN_CONT (pr_cont) to a couple of messages > o Added "PM: " (pr_info) to an #ifdef'd message > o Added "PM: " (pr_info) to a printk "Syncing filesystems ..." > in power/user.c The patch as is conflicts with the changes I have queued up for 2.6.33 (they'll appear in linux-next after I've fixed all build issues, hopefully tomorrow). For one example, we're dropping swsusp.c altogether. Also, I'm not a big fan of automatic conversions from printk() to pr_something() other than pr_debug(). Thanks, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
